Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(RHTAPWATCH-592): Create a README in o11y/exporter/dsexporter/ and add blurb about exporters in the root README #173

Merged
merged 1 commit into from
Feb 16, 2024
Merged

chore(RHTAPWATCH-592): Create a README in o11y/exporter/dsexporter/ and add blurb about exporters in the root README #173

merged 1 commit into from
Feb 16, 2024

Conversation

Kousalya1998
Copy link
Contributor

  • Add README.md under o11y/exporter/dsexporter/
  • Add blub about exporters in the root README.md

@Kousalya1998 Kousalya1998 marked this pull request as draft January 19, 2024 00:27
@Kousalya1998 Kousalya1998 marked this pull request as ready for review January 25, 2024 11:57
@yftacherzog
Copy link
Member

@Kousalya1998 can you break all lines at ~90 chars?

@Kousalya1998
Copy link
Contributor Author

@Kousalya1998 can you break all lines at ~90 chars?

Updated

eisraeli
eisraeli reviewed Jan 28, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
eisraeli
eisraeli reviewed Jan 28, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@eisraeli
Copy link
Contributor

eisraeli commented Jan 28, 2024 •
edited
Loading

IMO, the changes in the root README.md are redundant as the information already exists here
We should just reference to it.

Same goes for the information about Prometheus exporters in exporters/dsexporter/README.md

@yftacherzog
Copy link
Member

@Kousalya1998 can you break all lines at ~90 chars?

Updated

Most lines are still very long.

@Kousalya1998
Copy link
Contributor Author

@Kousalya1998 can you break all lines at ~90 chars?

Updated

Most lines are still very long.

I updated the README now.

@eisraeli
Copy link
Contributor

eisraeli commented Feb 5, 2024

@Kousalya1998 can you break all lines at ~90 chars?

Updated

Most lines are still very long.

@Kousalya1998 Can you please address is issue as well ?

hmariset
hmariset requested changes Feb 5, 2024
View reviewed changes
exporters/dsexporter/README.md Outdated Show resolved Hide resolved
@Kousalya1998
Copy link
Contributor Author

Kousalya1998 commented Feb 6, 2024 •
edited
Loading

@Kousalya1998 can you break all lines at ~90 chars?

Updated

Most lines are still very long.

@yftacherzog @eisraeli I don't know why for some reason my vscode shows like I have already indented them. I referred to the GitHubs README and updated the indentation again.

hmariset
hmariset approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@hmariset hmariset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

amisstea
amisstea requested changes Feb 12, 2024
View reviewed changes
exporters/dsexporter/README.md Outdated Show resolved Hide resolved
exporters/dsexporter/README.md Outdated Show resolved Hide resolved
@Kousalya1998
Copy link
Contributor Author

@amisstea Need your approvals to merge this PR

amisstea
amisstea reviewed Feb 14, 2024
View reviewed changes
exporters/dsexporter/README.md Outdated Show resolved Hide resolved
exporters/dsexporter/README.md Outdated Show resolved Hide resolved
@Kousalya1998
Copy link
Contributor Author

@amisstea @hmariset PTAL at the PR. Updated the README.

amisstea
amisstea reviewed Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@amisstea amisstea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content is now alright but please break up all lines exceeding 100 chars to improve readability.

@amisstea amisstea mentioned this pull request Feb 16, 2024
Merged
@amisstea amisstea merged commit b11bd63 into redhat-appstudio:main Feb 16, 2024
2 checks passed
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amisstea amisstea amisstea approved these changes

@hmariset hmariset hmariset approved these changes

@eisraeli eisraeli Awaiting requested review from eisraeli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Kousalya1998 @yftacherzog @eisraeli @amisstea @hmariset @klakshma21